In short, no. Do NOT accept the free upgrade unless you know what to do if everything goes wrong as it often does.
Just about everyone who worked with the evaluation and testing versions say it's OK. A lot of people who've upgraded say it's OK BUT, there's a lot of people out there who've gone for the free upgrade and regretted every second.
It's not that 10 is intrinsically that bad, it's better than 8 but that's all you can say about it. The real problem lies with the upgrade process, it's just too unreliable.
Almost everyone who has opted to do a clean installation of 10 says it works with few exceptions but that comes at a cost. The price of 10 starts around £80.
My bottom line is, if it ain't broke, don't fix it. Only go for 10 if you REALLY want to have the latest version of windows. It certainly isn't any better than 7.
OK, I've got XP, what should I do?
That's easy. Get Linux Mint. It has an appearance of win 7 and is free. Mint has a crisp, clean appearance and is built on the ever popular Ubuntu version but with a different appearance not too dissimilar to 7 making it easy for windows users to cross over.
Unless you have specialist needs, Linux Mint will work for you.
Opinions are those of the writer.
Trade marks and brand names acknowledged.